fix(ttf): name the offending codepoint when no glyph is available#1931
Open
NadeemIqbal wants to merge 1 commit into
Open
fix(ttf): name the offending codepoint when no glyph is available#1931NadeemIqbal wants to merge 1 commit into
NadeemIqbal wants to merge 1 commit into
Conversation
`TtfWriter.withChars` falls back to `glyphsMap.values.first` when the requested glyph index isn't in the subset cache. If every glyph has already been consumed (e.g. a font that has no glyph for an Arabic Presentation Form codepoint AND no surrounding chars added other glyphs), that `.first` call throws the generic Dart-runtime error `Bad state: No element`, which gives the user zero clue what input triggered it. Reformulate the fallback as an explicit if/else and, in the truly-empty case, raise a clearer exception that names the offending character and its Unicode codepoint (and the font that lacks it). The non-empty fallback path is preserved bit-for-bit — only the otherwise-untyped runtime crash is replaced. Closes DavBfr#1919.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TtfWriter.withCharsfalls back toglyphsMap.values.firstwhen the requested glyph index isn't in the subset cache. If every glyph has already been consumed (e.g. a font that has no glyph for an Arabic Presentation Form codepoint AND no surrounding chars added other glyphs), that.firstcall throws the generic Dart-runtime errorBad state: No element, which gives the user zero clue what input triggered it.Reformulate the fallback as an explicit if/else and, in the truly-empty case, raise a clearer exception that names the offending character and its Unicode codepoint (and the font that lacks it). The non-empty fallback path is preserved bit-for-bit — only the otherwise-untyped runtime crash is replaced.
Closes #1919.